-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update pull-request template #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The change makes sense, but I have a couple of comments.
Also, sorry for the long review -- we're getting used to developing in the open.
Thanks for the review! I did my first attempt to resolve your comments. Please let me know if any changes are still required after my comments - I will gladly fix them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution!
What ❔
This PR updates pull-request template to use uniform heading levels.
Why ❔
Heading level 1 on "What ❔" seems to be a mistake. It should have heading level 2 like the rest of headings.