Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pull-request template #225

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

hyunchel
Copy link
Contributor

What ❔

This PR updates pull-request template to use uniform heading levels.

Why ❔

Heading level 1 on "What ❔" seems to be a mistake. It should have heading level 2 like the rest of headings.

@hyunchel hyunchel requested a review from a team as a code owner October 15, 2023 14:29
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The change makes sense, but I have a couple of comments.
Also, sorry for the long review -- we're getting used to developing in the open.

@hyunchel
Copy link
Contributor Author

Thanks for the review! I did my first attempt to resolve your comments. Please let me know if any changes are still required after my comments - I will gladly fix them.

popzxc
popzxc previously approved these changes Oct 27, 2023
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

@popzxc popzxc enabled auto-merge October 27, 2023 12:45
auto-merge was automatically disabled October 30, 2023 12:46

Merge queue setting changed

@popzxc popzxc enabled auto-merge November 7, 2023 09:31
@popzxc popzxc added this pull request to the merge queue Nov 7, 2023
Merged via the queue into matter-labs:main with commit 2df8144 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants