Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: precommit script tracks size snapshots #2243

Merged
merged 3 commits into from
Jun 11, 2024
Merged

fix: precommit script tracks size snapshots #2243

merged 3 commits into from
Jun 11, 2024

Conversation

mlrawlings
Copy link
Member

@mlrawlings mlrawlings commented Jun 3, 2024

Description

  • updates the precommit script to git add the .sizes directory
  • switches from optimizeRegistryIds to optimizeKnownTemplates to ensure templates are given ids in a deterministic order

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Jun 3, 2024

⚠️ No Changeset found

Latest commit: 10533af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.48%. Comparing base (e7ff94c) to head (10533af).

Files Patch % Lines
packages/babel-utils/src/tags.js 97.82% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2243   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files         333      333           
  Lines       33838    33840    +2     
  Branches     1860     1860           
=======================================
+ Hits        29602    29606    +4     
+ Misses       4225     4223    -2     
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlrawlings mlrawlings merged commit 21d2601 into main Jun 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant