-
Notifications
You must be signed in to change notification settings - Fork 23
Revitalize CI #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revitalize CI #96
Conversation
…r supported)." This reverts commit ecd761a.
Thanks! I'll take a look tonight. |
@maoe - I also have ghc-9.6-support in place, but I thought two different PR's might be better, so I started this one first 😉 So if you take a look at it later maybe you also want to merge https://github.com/alaendle/influxdb-haskell/tree/feature/ghc-9.6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
INFLUXDB_VERSION: 1.8.4 | ||
services: | ||
influxdb: | ||
image: influxdb:1.8.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know it's available like this. Nice!
Sorry I missed this comment. Could you please send a PR for that? |
Sure, here is the PR for ghc 9.6 #97. |
Some remarks:
haskell-ci.yml
(to include influxdb service & allow localhost access from another container). No further changes - so another regeneration should be easy.cabal check
- changes ininfluxdb.cabal
cabal.haskell.ci
to only build documentation (haddock) on newer GHC's (because older haddock versions don't parse newer code)JSON.hs
)-XOverloadedLists
- this gives very strange results with ghc 9.4.5 - so changedUDP.hs
(to mimicWrite.hs
)regressions.hs
to accept parser failure from different aeson versions.So I think the change-set is relatively straightforward - and I hope ready to merge.
Before a new release is made we should maybe consider supporting ghc 9.6 (in a new PR)?