Add more instructions for running tests #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What === Add more instructions for running tests. Why === For those starting out and not familiar with how to get a PostgresSQL up and running for tests some examples would be helpful.
maddyblue
reviewed
May 22, 2018
TESTS.md
Outdated
| ## Running Tests | ||
|
|
||
| `go test` is used for testing. A running PostgreSQL server is required, with | ||
| the ability to log in. The database to |
There was a problem hiding this comment.
can you do something to fix this line wrapping? either fmt or one sentence per line. i don't care.
There was a problem hiding this comment.
I'm happy to fix it however is needed, but it's not clear how it should be formatted based off the existing code. Right now I formatted it as wrap at 80 chars and I retained the two character spacing between sentences. How should I fix it?
There was a problem hiding this comment.
`go test` is used for testing. A running PostgreSQL
server is required, with the ability to log in. The
database to connect to test with is "pqgotest," on
"localhost" but these can be overridden using [environment
variables](https://www.postgresql.org/docs/9.3/static/libpq-envars.html).
maddyblue
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add more instructions for running tests.
Why
For those starting out and not familiar with how to get a PostgresSQL
up and running for tests an example would be helpful. This isn't
supposed to define the only way to run the tests, but just provide an
example for those who have less experience and need a helping hand.