Skip to content

Add support for NamedValueChecker interface #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2023
Merged

Add support for NamedValueChecker interface #1125

merged 1 commit into from
May 3, 2023

Conversation

tamird
Copy link
Collaborator

@tamird tamird commented Apr 27, 2023 •
edited
Loading

Closes #640.

@tamird tamird force-pushed the named-value-checker branch from e8dd9d2 to b20d8fd Compare April 27, 2023 22:19
@tamird tamird force-pushed the named-value-checker branch 3 times, most recently from 4d7b547 to f0d37c0 Compare April 27, 2023 22:32
cbandy
cbandy reviewed Apr 27, 2023
View reviewed changes
@tamird tamird force-pushed the named-value-checker branch 7 times, most recently from d3fe2c0 to b702127 Compare April 27, 2023 23:04
@tamird
Copy link
Collaborator Author

tamird commented Apr 27, 2023

@cbandy this is passing now.

@tamird tamird force-pushed the named-value-checker branch from b702127 to b8a3e78 Compare April 27, 2023 23:11
cbandy
cbandy reviewed Apr 28, 2023
View reviewed changes
@tamird tamird force-pushed the named-value-checker branch 7 times, most recently from c6b0e3b to 8e98d33 Compare April 28, 2023 17:31
@tamird
Copy link
Collaborator Author

tamird commented Apr 28, 2023

@cbandy ping.

cbandy
cbandy reviewed Apr 29, 2023
View reviewed changes
@tamird tamird force-pushed the named-value-checker branch from 8e98d33 to 353eb52 Compare April 29, 2023 19:16
@tamird
Copy link
Collaborator Author

tamird commented Apr 29, 2023

@cbandy this is green now.

@tamird
Copy link
Collaborator Author

tamird commented May 2, 2023

@cbandy ping.

cbandy
cbandy approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@cbandy cbandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tamird, I am not a maintainer here. Someone else will need to review and/or merge.

@tamird
Copy link
Collaborator Author

tamird commented May 3, 2023

@otan can you take a look please?

@otan otan merged commit 381d253 into master May 3, 2023
@tamird tamird deleted the named-value-checker branch May 3, 2023 23:09
acoshift pushed a commit to moonrhythm/pq that referenced this pull request May 4, 2023
@tamird @acoshift
Add support for NamedValueChecker interface (lib#1125)
402d43b 
Added in 1.9: https://go.dev/doc/go1.9#minor_library_changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbandy cbandy cbandy approved these changes

@otan otan otan approved these changes

Assignees

@otan otan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamird @cbandy @otan