Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] FVM Preamble in fvm flutter #288

Closed
4 tasks done
nicholasspencer opened this issue May 6, 2021 · 2 comments
Closed
4 tasks done

[BUG] FVM Preamble in fvm flutter #288

nicholasspencer opened this issue May 6, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@nicholasspencer
Copy link

Before creating a bug report please make check the following

  • You have read our FAQ
  • If you have used flutter. Please install correctly, run pub cache repair. Close the terminal and try again.
  • If you are on Windows. Make sure you are running the terminal as administrator or with developer permissions.
  • Run fvm doctor if possible and add the output to the issue.

Describe the bug
fvm flutter injects logging into the output. This can be problematic when you're using fvm flutter pub run and expecting a certain output from the tool that was ran.

To Reproduce
Steps to reproduce the behavior:

  1. Go to terminal..
  2. Run fvm flutter pub run <some package executable>...
  3. See fvm's preamble

Expected behavior
The output from the ran executable.

Logs
N/A

Additional context
We noticed this in our CI pipeline. We use fvm to pin the version that CI uses which is great, thank you for that. However we also use a few of our own tooling that is executed with fvm flutter pub run and we're expecting that the output is the tool's output.

In my opinion, that preamble should only print if the --verbose is passed in.

@nicholasspencer nicholasspencer added the bug Something isn't working label May 6, 2021
@leoafarias
Copy link
Owner

@nicholasspencer makes sense

@leoafarias
Copy link
Owner

Solved on version 2.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants