[5.8] Only allow strings for resolving facade roots #25525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of laravel#25497 and laravel#25512, all facades in core are now properly using service identifiers (strings) for resolving their "root" service from the container. This means that the hack for resolving objects directly can now be removed. In case you're wondering why this is necessary: As far as I can tell, facade features like ::swap() did not work with these types of facades (Blade and Schema), because those methods did not deal with the possibility of objects being returned.
|
@tillkruss This would probably need a note in the changelog, to warn package developers who wrote their own facades. Not sure what the right procedure is in this regard, so I am tagging you. 🙈 |
|
Ping @themsaid. |
This was referenced Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #25497 and #25512, all facades in core are now properly
using service identifiers (strings) for resolving their "root"
service from the container. This means that the hack for resolving
objects directly can now be removed.
In case you're wondering why this is necessary: As far as I can
tell, facade features like ::swap() did not work with these types
of facades (Blade and Schema), because those methods did not deal
with the possibility of objects being returned.