make --admin configurable to rolling-update #17274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7dd560 to
0fb6ed3
Compare
justinsb
reviewed
Feb 21, 2025
0fb6ed3 to
6ddfae5
Compare
6ddfae5 to
d5cea90
Compare
This was referenced Feb 22, 2025
|
cc @hakman |
|
/retest |
|
Thanks for fixing - let's do it. I'm not sure if we need a flag, but we can always hide it, and it might get someone out of a jam... /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 24, 2025
…-upstream-release-1.32 Automated cherry pick of #17274: make --admin configurable to rolling-update
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 24, 2025
…-upstream-release-1.31 Automated cherry pick of #17274: make --admin configurable to rolling-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #17262 (comment)
this PR will add
--adminconfigurable to rolling-update command with default value 18 hourscc @justinsb