-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish docs with docsify #4193
Conversation
39e6205
to
b2d119a
Compare
This is using GitLab pages, but it's also possible (simpler?) to use GitHub Pages, we would move files into |
@Atoms is that what you had in mind? |
ci check this |
this seems awesome, just some 404 pops up |
also i would say github pages would be simpler, can we try there? |
a8f09eb
to
ccdc42f
Compare
OK. I refactored this to be GitHub Pages rather than GitLab Pages. Since GitHub pages works only on master, I made another fork to test this out:
And here is a screenshot of the GitHub Pages config, someone with owner access has to enable it on the kubernetes-sigs/kubespray repo. I would suggest to test things with https://kubernetes-sigs.github.io/kubespray/ then enable the kubespray.io custom domain once it's confirmed working (it's just a CNAME config https://help.github.com/articles/quick-start-setting-up-a-custom-domain/) |
@mattymo please enable github pages |
@Atoms github pages is enabled |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Atoms, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add docsify website * Add website CI
Using docsify to make a docs website
Mirror available here: https://miouge1.github.io/kubespray-docs/