Skip to content

add relaxed lookup-raw interface #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

khibino
Copy link
Contributor

@khibino khibino commented Jun 22, 2022

Add a new lookupRaw variant.
For example, the current time is not to be retrieved in the recv action, but passed from the outside.

@khibino khibino marked this pull request as ready for review June 22, 2022 08:26
@kazu-yamamoto kazu-yamamoto self-requested a review June 23, 2022 07:06
@kazu-yamamoto
Copy link
Owner

This PR itself looks good. But what about changing the argument order of "resolve"?
If you like, you can rebase your commit onto https://github.com/kazu-yamamoto/dns/tree/resolve.

@khibino khibino force-pushed the lookup-raw-with-recv branch from dea2182 to e2c3614 Compare June 24, 2022 01:51
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit 9f76118 into kazu-yamamoto:master Jun 24, 2022
@kazu-yamamoto
Copy link
Owner

Merged. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants