Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Patches to Remcom #15

Merged
merged 1 commit into from
Apr 19, 2012
Merged

Patches to Remcom #15

merged 1 commit into from
Apr 19, 2012

Conversation

andrese
Copy link

@andrese andrese commented Feb 13, 2012

Hi,

At last I was able to send the patches (total git noob here).

I have managed to make some patches improving 64 bit target support, and other minor changes.

There are issues opened for everything with more detailed comments.

As a summary this are the changes:

  • Modified to handle longer command parameters.
  • Changed directory to copy executables to \ADMIN$ instead of \ADMIN$\system32 in order to support 64 bits targets.
  • Changed RemCom output to be sent to stderr while the remote command writes to stdout.
  • Allow to scape '/' character to use it as part of remote command and its parameters.
  • Reclassified error return codes. Now RemCom returns its own return code, and the remote program return code is show at the stdout.
    //Return Codes:
    //
    // (-1) Incorrect parameters
    // (-2) Malformed credentials
    // (-3) Invalid target name
    // (-4) Bad credentials
    // (-5) Could not connect to target
    // (-6) Error copying executable
    // (-7) Error copying service
    // (-8) Error executing service
    // (-9) Error connecting to remote service
  • Patched to handle spaces in the filename (FIXED).
  • Tested with: win2k, winxp(32bits), win2003(32&64), win2008R2(32&64), win7(32&64).

Also I recompiled the binaries with ms studio 2003 (sorry no 2010 license) statically linking everything (so no redistrib is needed)

I am using right now RemCom as part of my software and its working fine .

I hope you approve the changes and accept them into the main branch.

Best Regards

Andrés

kavika13 added a commit that referenced this pull request Apr 19, 2012
Many bug fixes:

- Modified to handle longer command parameters.
- Changed directory to copy executables to \ADMIN$ instead of \ADMIN$\system32 in order to support 64 bits targets.
- Changed RemCom output to be sent to stderr while the remote command writes to stdout.
- Allow to escape '/' character to use it as part of remote command and its parameters.
- Reclassified error return codes. Now RemCom returns its own return code, and the remote program return code is show at the stdout. //Return Codes: // // (-1) Incorrect parameters // (-2) Malformed credentials // (-3) Invalid target name // (-4) Bad credentials // (-5) Could not connect to target // (-6) Error copying executable // (-7) Error copying service // (-8) Error executing service // (-9) Error connecting to remote service
- Patched to handle spaces in the filename (FIXED).
@kavika13 kavika13 merged commit c639ce9 into kavika13:master Apr 19, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants