Bestbuy-ca False Positives

[Axiotis]

Expected Behavior

Out of stock: Prompt says out of stock.
In stock: Prompt says its in stock, opens the webpage & adds to cart.

Current Behavior

Out of stock: Prompt says its in stock & opens the webpage.
None of the gpus I'm looking for have been in stock since issue first occurred, so I don't know in stock behavior.

Steps to Reproduce

Running v3.5.0

Happens ~50% of the checks on any gpu it searches for.

Ex. card:
https://www.bestbuy.ca/en-ca/product/msi-nvidia-geforce-rtx-3070-ventus-3x-oc-8gb-gddr6-video-card/15038016

I don't know much about HTML so this may be wrong, but I think they changed the add to cart button and the bestbuy-ca.ts is looking for a container that doesn't exist anymore?

Environment

• OS:
  Windows 10

dotenv

I reset to default config and changed only a few items to narrow down search, rest are default values.

LOW_BANDWIDTH=true
PAGE_SLEEP_MIN=100000
SHOW_ONLY_BRANDS=msi, EVGA, nvidia
SHOW_ONLY_SERIES=3060ti, 3070
STORES=bestbuy-ca

[pchouinardupgrade]

+1

getting many bestbuy-ca alerts and add to cart is never available

here is an example success image that was captured, there doesnt seem to be any buttons on the page:

[alexricher]

+1

Same issue here. Whenever I enable the search for bestbuy-ca, it keeps notifying me repetitively that there is something in stock (every few minutes or so, which is quite annoying) while there isn' anything in stockt. Sadly, I would love to monitor bestbuy.ca as it's one of the few places where the prices are still not too inflated.

My workaround for now is to keep it disabled, but that means I miss out whenever there is stock.

[bmierdel]

If you change the waitUntil in src\store\model\bestbuy-ca.ts to networkidle2 it seems to fix it.

I'd PR the fix but I'm not really interested in forking the repo

[Axiotis]

If you change the waitUntil in src\store\model\bestbuy-ca.ts to networkidle2 it seems to fix it.

I'd PR the fix but I'm not really interested in forking the repo

Unfortunately making this change doesn't seem to flag anything in stock for me, even with test items that are in stock.

[richie256]

@Axiotis check out my PR. I believe the way to resolve this is to check for inStock element instead of the outOfStock.