multiple entries for local IP in /etc/hosts prevents connecting

[irssibot]

• • • Issue multiple entries for local IP in /etc/hosts prevents connecting #167 opened by @xenon

  This bug is caused by using an /etc/hosts file with multiple entries for your local IP (happened on Mac OS X, not sure about others). Ideally people who run into this issue should fix their /etc/hosts file. Attached is a patch.

[irssibot]

• • • Attachment 51 by @xenon

irssi-hosts.patch

Patch to fix bug

diff -u irssi-2005.2.1/src/irc/core/irc-servers.c irssi-mod/src/irc/core/irc-servers.c
--- irssi-2005.2.1/src/irc/core/irc-servers.c	Tue Oct 12 13:10:02 2004
+++ irssi-mod/src/irc/core/irc-servers.c	Sun Jan  2 13:19:33 2005
@@ -142,8 +142,11 @@
 	}
 
 	/* Replace ':' with '_' in our own hostname (the same IPv6 problem) */
+	/* Replace '\n' and '\r' with '\0' in our own hostname to fix multiple PTR addreses */
 	for (ptr = hostname; *ptr != '\0'; ptr++) {
 		if (*ptr == ':') *ptr = '_';
+		if (*ptr == '\n') *ptr = '\0';
+		if (*ptr == '\r') *ptr = '\0';
 	}
 
 	/* don't allow hostname to begin with number or '+', '-'. those

[irssibot]

• • • Comment 215 by @xenon

Forgot to mention, this starts where if gethostname() returns multiple lines. This causes the USER command to fail.

[irssibot]

• • • Closed by @coekie