Control map multiple keys to one output #17215
Conversation
|
Hm, thinking as a user I do think suppressing the second key is logical. This is fairly consistent with existing interfaces, like Ctrl-F etc. so I think it would make the most sense. Probably doesn't need to be within this pull, though, but a good idea. -[Unknown] |
|
Accidental submodule updates slipped in. -[Unknown] |
|
Oh, no. |
1ebc588
to
33ba6f6
Compare
| confirmKeys.push_back(InputMapping(DEVICE_ID_PAD_0, NKCODE_BUTTON_2)); | ||
| cancelKeys.push_back(InputMapping(DEVICE_ID_PAD_0, NKCODE_BUTTON_3)); |
There was a problem hiding this comment.
A lot of controllers have different opinions on which buttons are which - I'm definitely not a fan of hardcoding these specific ones. Why do we need to do this and didn't before?
-[Unknown]
There was a problem hiding this comment.
I'm not a fan either, but these match with the "autodetect" mappings we use for DInput pads on Windows - which happen to match the PS4 controller I have.
I can't get it to navigate PPSSPP's menus with the PS4 controller without this. Does that work for you somehow?
But maybe we should just pick up from the bindings, at least on PC where you always have other options to navigate anyway...
There was a problem hiding this comment.
I can check later. It used to work just fine, of course. I'm sure there are some people who do couch gaming with dinput controllers on media pcs, still...
I thought this did use the bindings automatically, and I already have buttons mapped. I used to use (and still have) a controller that used different keys and it used to work fine in PPSSPP as well - after mapping it once. Forcing the wrong mappings seems bad. It's like the same stupid mistake the worst console->PC ports have made.
-[Unknown]
There was a problem hiding this comment.
We've always had hardcoded bindings just for the PPSSPP menus so that you can always navigate even if you accidentally clear the configurable bindings - would be really screwed on the NVIDIA Shield for example without that.
It's possible I broke something though, let me check an older build.
There was a problem hiding this comment.
Actually we already have code to try to pick up extra confirm/cancel buttons from the bindings. So I think I did break something.
There was a problem hiding this comment.
Yes this was just me screwing up. Fixed in the new PR.
Reimplementation of #17168, using the new control mapping system, but supports up to 3-key combos.
One thing I've been thinking about is that with this, if say you map RTrigger + Y to take a screenshot, it'll still send the individual RTrigger and Y while you're pressing it. I'm thinking that when you do a combo like that, maybe the individual press of the second key could be suppressed (can hardly suppress the first one..)...