Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU: Add setting to control inflight frame usage #12660

Merged
merged 2 commits into from
Mar 1, 2020

Conversation

unknownbrackets
Copy link
Collaborator

So that users can turn it off and be sure it's not a source of input lag.

Not super confident about the checkbox title, "Allow gameplay ahead of display (faster, input lag)", open to competing ideas...

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.10.0 milestone Mar 1, 2020
@hrydgard
Copy link
Owner

hrydgard commented Mar 1, 2020

"Buffering" or "Queue" can indicate a cause of latency - maybe "graphics command buffering" or "max queued frames" or something? Hm..

@unknownbrackets
Copy link
Collaborator Author

I've changed it to "Buffer graphics commands (faster, input lag)". I think it makes sense...

-[Unknown]

@hrydgard
Copy link
Owner

hrydgard commented Mar 1, 2020

Yeah, that's OK.

Hm, I'm wondering if it's interesting to allow a value of 2 as well? Might be useful as a compromise. Just figure thinking about this before we lock down the translation string...

@unknownbrackets
Copy link
Collaborator Author

Okay, added that. Used "Up to 2" to try to make it clear that it's not fixed at that.

-[Unknown]

@hrydgard hrydgard merged commit fa8968f into hrydgard:master Mar 1, 2020
@unknownbrackets unknownbrackets deleted the frame-latency branch March 1, 2020 23:18
@iota97
Copy link
Contributor

iota97 commented Mar 2, 2020

On Linux at least changing this in game cause all sort of problem (Missing tris, flicker, weird frame in between, emulator become unresponsive and need to be killed). It can even cause problem if you go in game, exit to main menu, change it and start another game (didn't manage to see any of them if changed before starting a game at all).

May be better to disable in game (and may require a restart like graphical API change)?

@unknownbrackets
Copy link
Collaborator Author

Hm, I hadn't reproduced that before but I'm seeing it now. Ideally, we should restart graphics (similar to when you resize on Android), but this will only work on some platforms. For example, Windows / OpenGL doesn't really have a way to restart graphics... we may have to restart indeed.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants