Fix development instructions #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jul 30, 2019
README.md
Outdated
| @@ -10,7 +10,7 @@ This is the repository for the official [Home Assistant](https://home-assistant. | |||
|
|
|||
| ## Development | |||
|
|
|||
| - Initial setup: `script/setup` | |||
| - Initial setup: `script/bootstrap` | |||
There was a problem hiding this comment.
We follow the Scripts to rule them all approach. Setup is used for initializing the project. I think that instead of making this change, we should add a setup script that calls bootstrap script.
script/setup did not exist, despite being mentioned in the readme. Create it and let it call bootstrap.
|
Thanks ! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
script/setup exists for the main home-assistant repo, but not for the frontend.
The bottom part of this change was generated by the git commit-hook.