Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase generic entity row touch target #23894

Merged

Conversation

insomniac2305
Copy link
Contributor

Proposed change

This PR implements the suggestions of #18461 and increases the touch target size of the generic entity row. This is accomplished by setting the minimum height of the entire row to that of the state badge, which is fixed to 40px. Additionally it changes the margin of the info text to be padding instead, in order to remove the gaps in the touchable area.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@MindFreeze MindFreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MindFreeze MindFreeze merged commit b3391b3 into home-assistant:dev Jan 27, 2025
16 checks passed
@insomniac2305 insomniac2305 deleted the increase-entity-row-touch-target branch February 2, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entities card has too small touch targets
2 participants