Re-remove time picker for Energy

[karwosts]

Proposed change

The time picker seems accidentally added to Energy during some boolean attribute refactoring. It doesn't function and shouldn't be there, I think only whole days are supported.

From: #23189

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes Time range is not working in energy dashboard #23882
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[silamon]

Can't we just revert to the code it was? Having inverse code logic in the middle of passing through makes it harder to maintain.

[karwosts]

I am not confident what the best way forward is. I remember a few times having similar discussions and I had the thought that having any attribute with a default value of true was discouraged, as it could not be changed via attribute.

So I don't know if this property should have the attribute removed, or what is the best fix.

[silamon]

I am not confident what the best way forward is. I remember a few times having similar discussions and I had the thought that having any attribute with a default value of true was discouraged, as it could not be changed via attribute.

So I don't know if this property should have the attribute removed, or what is the best fix.

Just had a quick look and it may be easier to remove the time picker attribute here, change the default then from true to false in the ha-date-range-picker and add the time-picker attribute to history and logbook.

[MindFreeze]

@silamon 's suggestion sounds good. Using attributes to add things instead of removing them makes sense

[karwosts]

Updated.

[MindFreeze]

awesome