Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete button for state content in iOS #23839

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jan 22, 2025

Proposed change

Delete icon didn't work on iOS.

I tested the fix in multiple browser :

  • Android Chrome,
  • iOS Safari
  • desktop Safari
  • desktop Chrome
  • desktop Firefox

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 51e6e6d into dev Jan 22, 2025
16 checks passed
@balloob balloob deleted the fix_state_content_picker_ios branch January 22, 2025 13:16
@wendevlin
Copy link
Contributor

This introduced the bug on Android Chrome 14, I'll try to find a way to work for all.

@piitaya
Copy link
Member Author

piitaya commented Jan 22, 2025

Here's the fix for Android and iOS : #23847

@piitaya piitaya added this to the 2025.1 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants