Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember selection "Don't Group" in data-tables #23836

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Jan 21, 2025

Proposed change

Data tables seem like they intend to remember user's selected grouping preference, but when selecting "Don't group" it would always reset to the default "Group by category" every time you returned to the page.

This change keeps "group by category" as default when logging in with no sessionStorage, but if you select "Don't group" it will keep persistent like the other selections.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze merged commit b3141a0 into home-assistant:dev Jan 22, 2025
16 checks passed
@karwosts karwosts deleted the dont_group branch January 22, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants