Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make add integration dialog keyboard accessible #23829

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Jan 21, 2025

Proposed change

Make the add integration dialog keyboard accessible:

  • Remove escapeKeyAction to enable closing via Esc, in my opinion this isn't a dialog where we should prevent this as by dialogs where a user should fill out a form.
  • Prevent focusing/tabbing the lit-virtualizer
  • Allow tabbing through the ha-integration-list-item
  • Allow selecting a integration with Enter when focused

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@jpbede jpbede changed the title Make add integration keyboard accessible Make add integration dialog keyboard accessible Jan 21, 2025
@MindFreeze MindFreeze merged commit 7aa2abc into home-assistant:dev Jan 22, 2025
16 checks passed
@jpbede jpbede deleted the add-integration-accessibility branch January 22, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration dialog is not keyboard accessible
2 participants