Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow storing temperature/humidity entities on an area #23822

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

balloob
Copy link
Member

@balloob balloob commented Jan 21, 2025

Breaking change

Proposed change

Update the edit area dialog to allow storing temperature/humidity sensors on an area. Limits entities to the ones contained in the area.

Backend is already merged

(There are a lot of cool things that we can do with this, including dashboard strategies, showing this data on area info page and what not. That's for other PRs by other people :) )

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Design Related to Home Assistant design gallery label Jan 21, 2025
@wendevlin wendevlin requested a review from piitaya January 21, 2025 08:06
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can consider splitting these settings because it become too big.
Also, we should explain to the user where these entities will be used (dashboard, voice, etc...)
Code wise, it is ok for me 🙂

Note : We should add an area and a device parameter to the entity-picker/entity-selector so we don't need to build a specific filter for that.

@piitaya piitaya merged commit 9e868e1 into dev Jan 21, 2025
15 checks passed
@piitaya piitaya deleted the allow-storing-temperature-humidity branch January 21, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Design Related to Home Assistant design gallery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants