-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce backup switch when updating core and addons #23814
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
211569f
to
76594b0
Compare
wendevlin
reviewed
Jan 21, 2025
76594b0
to
fa38441
Compare
wendevlin
previously approved these changes
Jan 21, 2025
8b5efbb
to
6f05010
Compare
Core PR is approved. |
wendevlin
approved these changes
Jan 27, 2025
I was not missing this option... I have a daily backup so I always have to turn off this option. Would it be possible to make it remember the last selection? Can be as simple as a general on/off per browser. |
It will be off by default. |
@piitaya 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Core PR:
Re-introduce the backup switch when updating core or an addon :
Trigger automatic backup when updating core
Create "add-on" backup when updating add-on (more info)
Create "add-on" backup when updating add-on (add-on page)
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: