-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from chart.js to echarts #23809
Conversation
The proposal area of the PR form is blank. Providing some sort of write-up explaining the reasons behind the change would help, especially for such a large PR. |
@steverep it's not ready. Have patience, please |
Ah ok, yeah then I would leave it as it is. |
I still have the issues:
|
Should be fixed now |
Would you like me to start opening issues related to this, or do you want more time to work on it and I'll wait for the beta? Have to say this is looking pretty rough at the moment, see quite a lot of visual problems 😬 |
Please open an issue and assign it to @MindFreeze. Thanks! |
While generally this is a nice change, it is a step back for the graphs legend. In this discussion (#24112) I proposed a change that brings back the old legend. (DerDaku@5595194) Sadly my typescript skills are somewhat basic, so it is probably not ready to be added to home assistant (if it is even wanted). Is there anyone that could have a look at it and provide feedback? |
Breaking change
This could break custom styling but is non breaking for HA directly
Proposed change
Remove Chart.js and replace it with Echarts
Pros:
Cons:
Known current issues
Sometimes zoom with ctrl/cmd + scroll doesn't work until you focus(click) a chartpointer
when hovering over a line as mentioned by @wendevlin below. See this commentClick to open
more-info
has not been migrated as it was decided to remove this from charts but we should replace it with something else.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: