Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture glance alignment fix #23793

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

ildar170975
Copy link
Contributor

@ildar170975 ildar170975 commented Jan 19, 2025

Breaking change

Proposed change

Test code:

camera_view: auto
type: picture-glance
title: Kitchen
image: /local/images/test/blue.jpg
entities:
  - entity: input_boolean.test_boolean
  - entity: sun.sun
  - entity: sun.sun
  - entity: input_boolean.test_boolean
  1. Icons were misaligned:
    Before:
    image

Better visible with mdi:circle:
image

After:
image
image

Preferred to fix a font-size for picture-glance only (not globally for all ha-state-icon elements).

  1. Long title was not cut & causing some icons not displayed.
    Before:
    image

Seems that these lines did not work for .title:
image

After:
image

  1. Title was misaligned:
    Before:
    image

After:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975 ildar170975 marked this pull request as ready for review January 19, 2025 05:21
Copy link
Contributor

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix. Thanks @ildar170975 🎉

@wendevlin wendevlin merged commit 9a3ca59 into home-assistant:dev Jan 20, 2025
15 checks passed
@ildar170975 ildar170975 deleted the picture-glance-align branch January 20, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants