Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use destructive attribute from ha-button #23786

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Jan 18, 2025

Proposed change

Instead of copying around the .destructive class for ha-button use the new destructive attribute (introduced in #23774).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code improvement. Thanks @jpbede I just did a small simplification.

@wendevlin wendevlin merged commit 2f5fd6f into home-assistant:dev Jan 20, 2025
15 checks passed
@jpbede jpbede deleted the ha-button-destructive branch January 20, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants