-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve add cards dialog user experience #23773
Improve add cards dialog user experience #23773
Conversation
The height of the dialog content is a bit tweaked so it fits. Alternatively, you can have a sticky search bar (top 0), force the background the same way you did as the card container title. Then to finish off, use sticky card container title with top set to 56px being the height of the search input. |
Thnx @silamon for that great suggestion. This is indeed way cleaner 🙏 |
Nice 👍 I don't like that the title wrappers are so edgy. We could just have a background with round corners aground the title, the rest of the title line is transparent. Moreover what about align the card to top of the wrapper? When there is a big card on the row a small card can be far away from the title. I would see it easier on the top of the wrapper. @marcinbauer85 |
I like that idea 👍 |
@wendevlin @jpbede let's please use a gradient background instead to soften the transition: @jpbede One additional thing that you could fix here is that it's impossible to tab through this dialogs content and select a card by keyboard alone, hence making this not accessible for people relying on only keyboards or screen readers. |
@jpbede When you search the result styles are broken. I saw you have removed the card-container around search results, this leads to the issue. |
Oh okay, will look into it, thanks. |
I moved the card container around the sections, so the card container headers wont stack and forgotten to add it around the search results |
src/panels/lovelace/editor/card-editor/hui-dialog-create-card.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed change
Improve the add cards dialog user experience based on the Figma proposal from the product team: #23717
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: