Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make media play button in media browser more visible when hovering #23760

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Jan 15, 2025

Proposed change

Make the play button in the media browser a bit more visible by reducing the brightness of the image and styling the button itself like a fab. This also fixes the misalignment (was more aligned to the top) of the button 🙂

Old New
image image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@jpbede jpbede changed the title Make media play button in media browser more visible Make media play button in media browser more visible when hovering Jan 15, 2025
Copy link
Contributor

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Jan-Phillipp,

Thanks for this nice improvement.

I just found some tiny improvements.

src/components/media-player/ha-media-player-browse.ts Outdated Show resolved Hide resolved
src/components/media-player/ha-media-player-browse.ts Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 16, 2025 08:55
@jpbede jpbede marked this pull request as ready for review January 16, 2025 09:28
@home-assistant home-assistant bot requested a review from wendevlin January 16, 2025 09:28
@wendevlin wendevlin added the Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Jan 16, 2025
@wendevlin wendevlin merged commit e5d2f2d into home-assistant:dev Jan 16, 2025
15 of 16 checks passed
@jpbede jpbede deleted the play-button-visiblility branch January 16, 2025 09:54
@jpbede jpbede mentioned this pull request Jan 17, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image / Media management - add buttons can sometimes be hard to see
2 participants