Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if we can decrypt backup on download #23756

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Jan 15, 2025

Proposed change

Checks if a backup can be encrypted and if the current encryption key is the correct one, otherwise asks for the encryption key on download.

  • if a backup decryption is unsupported it shows an info about that and download encrypted
  • If the user forgot the encryption key he/she can download it encrypted

Needs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya force-pushed the check-if-we-can-decrypt-backup-on-download branch from c7d94a4 to 9e1038b Compare January 21, 2025 11:08
@wendevlin wendevlin merged commit fcb6da5 into dev Jan 21, 2025
15 checks passed
@wendevlin wendevlin deleted the check-if-we-can-decrypt-backup-on-download branch January 21, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants