Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast views not showing a background #23724

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Jan 13, 2025

Proposed change

Comparing cast dashboards with regular dashboards, there's a css rule to set the childs of hui-view to maximum width. That rule was only applied to the view (and not the background) for casted views.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Cast Related to Home Assistant Cast UI label Jan 13, 2025
@silamon silamon added this to the 2025.1 milestone Jan 13, 2025
@bramkragten bramkragten self-assigned this Jan 14, 2025
@bramkragten bramkragten mentioned this pull request Jan 14, 2025
9 tasks
bramkragten
bramkragten previously approved these changes Jan 14, 2025
@bramkragten
Copy link
Member

Does not fix the problem, but still a good to merge 👍

@wendevlin
Copy link
Contributor

I think this is related:

@silamon
Copy link
Contributor Author

silamon commented Jan 14, 2025

I think this is related:

Probably this one: #23731
In that regard I marked yours to be cherry picked.

Does not fix the problem, but still a good to merge 👍

Feel free to merge, but if it doesn't fix anything at all, I don't see why we should merge.

@silamon silamon removed this from the 2025.1 milestone Jan 14, 2025
@bramkragten bramkragten marked this pull request as ready for review January 15, 2025 09:47
@bramkragten
Copy link
Member

Feel free to merge, but if it doesn't fix anything at all, I don't see why we should merge.

To make sure cast and non cast are aligned :-)

@bramkragten bramkragten merged commit 6288154 into home-assistant:dev Jan 15, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cast Related to Home Assistant Cast UI cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants