Update ts-eslint #23723
Merged
Update ts-eslint #23723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice to see this, I expected more issues though, but I see you turned the associated rules off. |
silamon
previously approved these changes
Jan 13, 2025
Yeah it would have lead to too much changes |
silamon
previously approved these changes
Jan 14, 2025
…ipt-eslint-update
bramkragten
reviewed
Jan 14, 2025
src/components/ha-ansi-to-html.ts
Outdated
| @@ -34,7 +34,7 @@ export class HaAnsiToHtml extends LitElement { | |||
|
|
|||
| @litState() private _filter = ""; | |||
|
|
|||
| protected render(): TemplateResult | void { | |||
| protected render(): TemplateResult | undefined { | |||
There was a problem hiding this comment.
When does this return undefined?
There was a problem hiding this comment.
🤷 I just replaced void with undefined, I'll remove it.
bramkragten
reviewed
Jan 14, 2025
...panels/config/integrations/integration-panels/zwave_js/dialog-zwave_js-remove-failed-node.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Jan 14, 2025
bramkragten
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
update typescript-eslint to v8
remove
airbnb-typescript/basecloses Update typescript-eslint monorepo to v8 (major) #21574
Type of change
Example configuration
Additional information
In a future PR there should be
plugin:@typescript-eslint/stylisticincluded to our config.Checklist
If user exposed functionality or configuration variables are added/changed: