-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Externalize ha-assist-chat styling #23713
Conversation
cb881ec
to
f1bc9ac
Compare
I pushed a fix. The problem was that |
src/components/ha-assist-chat.ts
Outdated
@@ -498,7 +496,7 @@ export class HaAssistChat extends LitElement { | |||
bottom: 0px; | |||
right: 0px; | |||
left: 0px; | |||
padding: 24px; | |||
padding-bottom: 16px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The x padding added a space betweren the chat bubbles and the scrollbar. Now it sticks to the scrollbar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh good point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
f1bc9ac
to
a1a63c1
Compare
Breaking change
Proposed change
Move the margin out of
ha-assist-chat
so it can be easier embedded in other locations. Styling of assist dialog remains the same.Will help with styling for #23682
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: