Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize ha-assist-chat styling #23713

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Externalize ha-assist-chat styling #23713

merged 3 commits into from
Jan 16, 2025

Conversation

balloob
Copy link
Member

@balloob balloob commented Jan 12, 2025

Breaking change

Proposed change

Move the margin out of ha-assist-chat so it can be easier embedded in other locations. Styling of assist dialog remains the same.

CleanShot 2025-01-12 at 16 38 59@2x

Will help with styling for #23682

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob force-pushed the external-ha-assist-chat branch from cb881ec to f1bc9ac Compare January 14, 2025 18:30
@balloob
Copy link
Member Author

balloob commented Jan 14, 2025

I pushed a fix. The problem was that ha-assist-chat had a min-height, dictating how it was to be used. However, it was going to be used slightly different now. Removed the min-height and moved that to the host.

@@ -498,7 +496,7 @@ export class HaAssistChat extends LitElement {
bottom: 0px;
right: 0px;
left: 0px;
padding: 24px;
padding-bottom: 16px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The x padding added a space betweren the chat bubbles and the scrollbar. Now it sticks to the scrollbar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh good point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@balloob balloob force-pushed the external-ha-assist-chat branch from f1bc9ac to a1a63c1 Compare January 16, 2025 01:20
@wendevlin wendevlin merged commit 173d60b into dev Jan 16, 2025
15 checks passed
@wendevlin wendevlin deleted the external-ha-assist-chat branch January 16, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants