Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline behavior for date-range-picker history and logbook #23710

Conversation

boern99
Copy link
Contributor

@boern99 boern99 commented Jan 12, 2025

Breaking change

Proposed change

Type of change

Firefox version 134 and 135 beta do not display textarea contents on one line when using "white-space: nowrap;".
Which results in the end date not being visible on desktops:
image

see also: #23671 and #23685

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@boern99 boern99 changed the title newline behaviour for date-range-picker only for mobiles Newline behavior for date-range-picker history and logbook Jan 12, 2025
@boern99 boern99 marked this pull request as ready for review January 12, 2025 20:31
Copy link
Contributor

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @boern99 🙂

@wendevlin wendevlin merged commit 6dbc044 into home-assistant:dev Jan 13, 2025
15 checks passed
boern99 added a commit to boern99/ha_frontend that referenced this pull request Jan 13, 2025
@kobuki
Copy link

kobuki commented Jan 24, 2025

Has this fix been incorporated into a 2024.01.x release? I don't see it mentioned in the official change logs.

@wendevlin
Copy link
Contributor

Has this fix been incorporated into a 2024.01.x release? I don't see it mentioned in the official change logs.

No we havn't tagged it. I'll tag it for next week

@boern99 boern99 deleted the nl-behavior-for-time-span-selector-DateRangePicker branch February 15, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants