Fix navigation from stacked dialogs with the same name

[MindFreeze]

Proposed change

When 2 the same dialog appears twice in the stack, the first closeDialog call closes both, so the second one is missing from the stack when the loop gets to it. Not sure the closing behavior should be changed but for the linked bug, checking the state is enough.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes Link to edit automation from entity dropdown menu "Related" no longer working core#134766
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[bramkragten]

Wouldn't it be better to make sure a dialog can never be in the open stack more than once? As it is technically not possible to have the same dialog open twice...

[MindFreeze]

then you won't be able to navigate back to the previous more info dialog but this is not possible even now so I guess you're right

[MindFreeze]

Added a check so a dialog can only be in the stack once. Still left the check in closeAll though because we aren't using forEach so the array item is not guaranteed to be there

[bramkragten]

We should btw clean up this stuff:

diff --git a/src/dialogs/more-info/ha-more-info-dialog.ts b/src/dialogs/more-info/ha-more-info-dialog.ts
index c37e337aa..ffb46c998 100644
--- a/src/dialogs/more-info/ha-more-info-dialog.ts
+++ b/src/dialogs/more-info/ha-more-info-dialog.ts
@@ -180,16 +180,6 @@ export class MoreInfoDialog extends LitElement {
   }
 
   private _setView(view: View) {
-    history.replaceState(
-      {
-        ...history.state,
-        dialogParams: {
-          ...history.state?.dialogParams,
-          view,
-        },
-      },
-      ""
-    );
     this._currView = view;
   }
 

[RMMTSLLP]

Hi Guys, The issue still appears to be still here after upgrading to 2025.1.3 was the fix implemented in this version?

[MindFreeze]

@RMMTSLLP This fix hasn't been released yet