Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the title fonts consistent across different pages #23688

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

stevenjoezhang
Copy link
Contributor

Proposed change

I've noticed that the structure of different panel pages in Home Assistant uses several different implementations. Some pages use the <div class="main-title"> element for their titles, while others use ha-top-app-bar-fixed (based on the Material Design's TopAppBarFixedBase). However, the former usually sets the title font size to 20px via CSS, while the latter does not, resulting in it being the default size. When switching between different panel pages, you can observe the jitter in the title font size. This pull request fixes this issue by adding several definitions for font-size.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 630b482 into home-assistant:dev Jan 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants