Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ERR_REQUIRE_ASYNC_MODULE error when executing gulp #23687

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jan 11, 2025

Proposed change

The latest Node.js versions 22 and 23 introduced a new type of error: ERR_REQUIRE_ASYNC_MODULE, which prohibits modules from requiring another module that includes a top-level await. This update has caused the current gulp scripts to fail. Currently, GitHub Actions of this repository is using Node.js version 20, so there are no issues, but if updated to the latest release of Node.js 22 and 23, the build will fail.

Screenshot 2025-01-12 at 1 44 52 AM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Build Related to building the code label Jan 11, 2025
@bramkragten bramkragten merged commit 54c78ec into home-assistant:dev Jan 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Related to building the code cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants