Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info dialog for conversation agent #23682

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Jan 11, 2025

Breaking change

Proposed change

This adds a more-info dialog for conversation agents. This allows users to directly try out a conversation agent without having to configure it in a voice assistant.

Builds on top of #23184

conversation.more.info.mov

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon
Copy link
Contributor

silamon commented Jan 11, 2025

It's the change from webpack to rspack that requires a little bit more memory than before.

@balloob balloob marked this pull request as ready for review January 12, 2025 04:31
@balloob balloob mentioned this pull request Jan 12, 2025
9 tasks
@bramkragten bramkragten merged commit d112872 into dev Jan 15, 2025
15 checks passed
@bramkragten bramkragten deleted the more-info-conversation branch January 15, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants