Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ICU string for proper countdown via "1 minute" #23636

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Jan 8, 2025

This PR was motivated by the comment of the Polish localizer who commented on Lokalise:

There should be a way to indicate the correct form of "minuta", depending on the number.
"1 minutę", "2 minuty", "5 minut" are all valid options, for example.

They could then add the line

  =2 {minuty}

to cover that special case, too.

Proposed change

Add ICU syntax to cover "1 minute" as one duration option:

The channel change has been initiated and will complete in {delay} {delay, plural,
  one {minute}
  other {minutes}
}.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon silamon merged commit 50fa8dd into home-assistant:dev Jan 8, 2025
15 checks passed
@NoRi2909 NoRi2909 deleted the patch-69 branch January 8, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants