Restore attributes removed from ha-entity-marker in ha-map

[karwosts]

Proposed change

In a recent change, I inadvertently removed attributes from ha-entity-marker that several users were relying on to identify specific markers in the DOM for styling.

This change restores those attributes for maximum backward compatibility, instead of being set as properties.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[bramkragten]

I don't think this is a good idea, it will impact performance just for a custom component and can be removed at any point again 🤷‍♂️

[karwosts]

Ok, I did not realize there was a performance difference between setting attribute and setting property. Thanks for checking.

If there's no way forward, feel free to close this.

[Mariusthvdb]

tbh, we never noticed any performance issue on the maps before with the attribute, even with more complex mods than the one I posted in the Discord channel.

But if that would truly be the case, and leaving out entity_id here would be permanent, would there be another possibility to get to the individual markers for the entity_id's?

If this was not planned in the first place, because of performance issues, as seems to be the case, please (re-)consider reinstating

[bramkragten]

Ok, I did not realize there was a performance difference between setting attribute and setting property. Thanks for checking.

If there's no way forward, feel free to close this.

I mean, it is small, but it removes the step of converting the attribute to a property.

[karwosts]

Should I have just done only entity-id as an attribute and left the other 3 as properties?

[bramkragten]

Should I have just done only entity-id as an attribute and left the other 3 as properties?

If thats the only one thats needed, yes 👍

Actually, I think I would prefer to fix this inside ha-entity-marker and set reflect: true on entityId, then it is fixed in 1 place and it doesnt matter how it is set, by property or attribute.

[Mariusthvdb]

letting you know this is working again, thank yvm.