Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localizable "Filtering by config entry" for Entities and Devices #23544

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Jan 2, 2025

Proposed change

Currently the banner "Filtering by config entry …………" does not get translated in both the Entities and the Devices panel:

image

This PR adds the string for localizing "Filtering by config entry" to the Entities panel and, referenced from there, to the Devices panel, too.

The hard-coded string is replaced by localizable key references in both panels.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

This commit adds two strings for localizing "Filtering by config entry" to the Entities panel and, referenced from there, to the Devices panel.
@NoRi2909 NoRi2909 changed the title Add localizable "Filtering by config entry" to en.json Add localizable "Filtering by config entry" for Entities and Devices Jan 2, 2025
@NoRi2909 NoRi2909 marked this pull request as ready for review January 2, 2025 10:37
@MindFreeze MindFreeze merged commit f043886 into home-assistant:dev Jan 6, 2025
15 checks passed
@bramkragten bramkragten added this to the 2025.1 milestone Jan 6, 2025
bramkragten pushed a commit that referenced this pull request Jan 6, 2025
…23544)

* Add localizable "Filtering by config entry" to en.json

This commit adds two strings for localizing "Filtering by config entry" to the Entities panel and, referenced from there, to the Devices panel.

* Replace "Filtering by config entry" with localizable key

* Replace "Filtering by config entry" with localizable key

* Add missing comma

* Add missing }

* Add missing }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters panel: 'Filtering by config entry' banner not localized
3 participants