Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History: Improve explanation of selections by including labels as 4th option #23479

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Dec 27, 2024

When you open the History page you are greeted with this explanation:

image

The use of "Start by …" shows that this information is targeted at beginners to guide them through this page. But it fails to point to the use of labels and the most interesting option to select any combination from the four groups.

Proposed change

This PR fixes this by rewording:

Select areas, devices, entities or labels above

This includes labels which are most useful in History as they allow you to select a long list of similar entities with just a single click. For example any kind of sensors of identical type like occupancy, or all interior lights etc.

It also makes it inherently clear that the really cool feature here is to select multiple entities at once to see them side-by-side or in a single graph.

For languages with three genders like German this has the additional benefit that using plural solves the issue that it's "der Bereich", "die Entität", "das Gerät" and "das Label" those all become "die Bereiche, Entitäten, Geräte, Labels" in plural. ;-)

To match that the error message for 'Add current view as card' is also adapted as the current "You need to select data first." is no correct sentence.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

This commit adds labels as the 4th option for data sources in history and the error message when you select 'Add current view as card' in that state from the overflow menu.
@silamon silamon merged commit 3fd3c80 into home-assistant:dev Dec 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History: Improve explanation of selections by including labels as 4th option
2 participants