Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developer-tools-template: allow "select all" for "rendered" #23456

Merged

Conversation

ildar170975
Copy link
Contributor

Breaking change

Proposed change

Currently we cannot quickly select all text in a "rendered" panel like this:
1.Select any text.
2.Press "Ctrl-A" to get all result text selected.
Instead all other labels (except a text in codemirror) get selected.

This fix allows the described scenario.
It contains:
-- disabling a user select a "view-wide";
-- enabling a select for the "rendered" panel;
-- (seems to be needed for iOS Companion app) setting user-select: initial for a .edit-pane .card-content part.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975
Copy link
Contributor Author

ildar170975 commented Dec 26, 2024

I am honestly not sure if we still need that extensions like

-ms-user-select
-webkit-user-select
-moz-user-select

but they are present in other places of Frontend so I decided to follow a trend.
Also, I noticed that:
-- in some source files only user-select is used w/o extensions;
-- is some source files the user-select is present before other extensions;
-- is some source files the user-select is not present at all, only extensions are used.
Hope someone more experienced will say if it is properly or wrong.

@ildar170975 ildar170975 marked this pull request as ready for review December 26, 2024 02:34
@MindFreeze
Copy link
Contributor

We don't need the prefixes. Removing -webkit-user-select will impact some old iphones but it's 5S and older from what I can find so it should be ok

@ildar170975
Copy link
Contributor Author

We don't need the prefixes

Shall I remove extensions then?

@MindFreeze
Copy link
Contributor

yes, please

@MindFreeze MindFreeze merged commit 60e5774 into home-assistant:dev Dec 27, 2024
15 checks passed
@ildar170975 ildar170975 deleted the dev-tools-template-user-select branch January 2, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants