Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve explanation of passive zones #23443

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

NoRi2909
Copy link
Contributor

Proposed change

Currently the explanation for passive zones says that they "are not used as location for device trackers" which contradicts the second sentence that says: "This is useful if you just want to use it for automations.

image

So the first sentence says that they are not used while the second says they are just used for automations.

This PR clarifies that by changing the first sentence to "not shown as" and adds people beside device trackers because (active) zone names show up as the state of people, too.

In addition it fixes the plural / singular mismatch between the two sentences.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Currently the explanation for passive zones says that they "are not used as location for device trackers" which is misleading and does not fit the second sentence that says: "This is useful if you just want to use it for automations.

This commit clarifies that by changing to "not shown as" and fixes the plural / singular mismatch between the two sentences.
@NoRi2909
Copy link
Contributor Author

We might want to use the word "state" instead of "location" in the first sentence. That a zone defines a location is inherently clear, so it does make sense to say exactly where they show up.

@NoRi2909 NoRi2909 marked this pull request as ready for review December 24, 2024 16:11
@MindFreeze MindFreeze merged commit 01bec32 into home-assistant:dev Dec 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants