Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backup translations #23365

Merged
merged 15 commits into from
Jan 8, 2025
Merged

Add backup translations #23365

merged 15 commits into from
Jan 8, 2025

Conversation

wendevlin
Copy link
Contributor

@wendevlin wendevlin commented Dec 20, 2024

Proposed change

  • Add all backup translations
  • The change encryption key dialog has been updated to match dialog steps defined in figma.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

src/translations/en.json Outdated Show resolved Hide resolved
@NoRi2909

This comment was marked as outdated.

@bramkragten
Copy link
Member

This PR is far from complete, backups are mostly untranslated atm

@piitaya piitaya force-pushed the backup-translations branch from 8de7c80 to 9a59768 Compare January 7, 2025 10:45
NoRi2909

This comment was marked as resolved.

src/translations/en.json Outdated Show resolved Hide resolved
src/translations/en.json Outdated Show resolved Hide resolved
Comment on lines +168 to +173
ha-md-list-item {
--md-item-overflow: visible;
}
ha-md-list-item .name {
word-break: break-word;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix for list item overflow.

@piitaya
Copy link
Member

piitaya commented Jan 8, 2025

Are those leading space characters intentional?

No I fixed them. Thank you 🙂

@piitaya piitaya marked this pull request as ready for review January 8, 2025 16:21
@piitaya piitaya added this to the 2025.1 milestone Jan 8, 2025
Copy link
Contributor

@silamon silamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be added:

@piitaya
Copy link
Member

piitaya commented Jan 8, 2025

Thank you! I will add these ones.

@piitaya piitaya merged commit f8264e4 into dev Jan 8, 2025
15 checks passed
@piitaya piitaya deleted the backup-translations branch January 8, 2025 20:05
bramkragten pushed a commit that referenced this pull request Jan 9, 2025
* Add translations

* Add summary and progress translations

* Add backups and settings translations

* Add backups page translations

* Add onboarding card translations

* Add settings translations

* Add details translations

* Translate delete

* Add data picker translations

* Use local add-ons

* Add encryption key translations

* Add new, generate and upload translations

* Add translations for restore backup

* Fix ts issue

* Add missing keys

---------

Co-authored-by: Paul Bottein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants