-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation/Script editor border-radius fix #23267
Merged
MindFreeze
merged 12 commits into
home-assistant:dev
from
ildar170975:automation_editor_disabled_radius
Dec 12, 2024
Merged
Automation/Script editor border-radius fix #23267
MindFreeze
merged 12 commits into
home-assistant:dev
from
ildar170975:automation_editor_disabled_radius
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MindFreeze
approved these changes
Dec 12, 2024
MindFreeze
added a commit
that referenced
this pull request
Dec 27, 2024
This reverts commit e9b2a83.
bramkragten
added a commit
that referenced
this pull request
Dec 30, 2024
bramkragten
pushed a commit
that referenced
this pull request
Dec 30, 2024
This reverts commit e9b2a83.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
"Disabled bar" was overflowing.
Related to: ha-automation-condition-row, ha-automation-action-row, ha-automation-trigger-row, ha-script-field-row.
Old code was like
w/o default values.
But even with default values it would cause artefacts.
So I removed these radiuses for
.disabled-bar
,.triggered
,.testing
and setoverflow: hidden
for ha-card.before:

after:

Another issue is with undesired radius for selected

ha-expansion-panel
under.disabled-bar
:but have not found a good solution yet.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: