Rspack #22807

wendevlin · 2024-11-13T13:27:51Z

Breaking change

Proposed change

change from webpack to rspack

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (thank you!)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example configuration

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue or discussion:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
There is no commented out code in this PR.
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

coderabbitai · 2024-11-13T13:27:58Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MindFreeze · 2024-11-19T11:41:57Z

I am getting these times for build_frontend:

Finished 'webpack-prod-app' after 3.35 min
Finished 'rspack-prod-app' after 1.3 min

And these for develop:

webpack Compiled successfully in 8.22s
rspack Compiled successfully in 5.60s

Live recompile is slower with rspack. 2-2.5s vs 0.6-0.7s for webpack. There seems to be some delay before rspack starts, so maybe this could be fixed if we find where the delay comes from.

build-scripts/rspack.cjs

Co-authored-by: Petar Petrov <[email protected]>

MindFreeze · 2024-11-25T13:27:22Z

The difference in bundle size with RegExp chunks is a bug in Rspack web-infra-dev/rspack#8529

build-scripts/rspack.cjs

steverep · 2024-12-09T16:56:08Z

build-scripts/rspack.cjs

@@ -168,10 +170,14 @@ const createWebpackConfig = ({
          stats: { assets: true, chunks: true, modules: true },
          transform: (stats) => JSON.stringify(filterStats(stats)),
        }),
-      !latestBuild &&
-        new TransformAsyncModulesPlugin({


Does rspack properly transpile TLA for the legacy build? I don't see anything about target support in their docs.

AFAICT, rspack has the same problem that webpack does. There are now a bunch of async functions in the legacy build that will cause errors on older browsers.

I'm not sure why this plugin was removed, but it should probably be added back.

... or #23234 and then the transform isn't needed.

It wasn't supported by rspack, I removed it and tested it with browser stack if it is necessary. Maybe I did a mistake here, will check again or your solution solves it 🙂

No worries... you probably just didn't test anything that was old enough to not support async functions. It's moot now that #23234 is merged.

I wrote that plugin so I'll have to see if I can quickly make it compatible with rspack for others.

Webpackbar did a rspack update, maybe you can take this as inspiration:

feat: support rspack unjs/webpackbar#149

steverep · 2024-12-14T20:18:27Z

build-scripts/rspack.cjs

@@ -102,7 +102,7 @@ const createRspackConfig = ({
        chunks: !isProdBuild
          ? // improve incremental build speed, but blows up bundle size
            new RegExp(
-              `^(?!.*(${Object.keys(entry).join("|")}|work(?:er|let))$)`
+              `^(?!(${Object.keys(entry).join("|")}|.*work(?:er|let))$)`


Why are we treating production and development builds differently? Looks like the regex is trying to accomplish the same thing for the modern build, but will give a different result for the legacy build? 😕

We had troubles with the incremental build speed, so we found this solution but it fucks up all our chunks so for prod we still use the js lambda. Yeah you are right, maybe we should also disable this for legacyBuild

wendevlin added 3 commits November 11, 2024 15:41

Add rspack

1d62466

Remove TransformAsyncModulesPlugin from rspack

e7a7f0e

Migrate all webpack usage to rspack

6ad3b48

home-assistant bot added the cla-signed label Nov 13, 2024

github-actions bot added the Build Related to building the code label Nov 13, 2024

wendevlin added 6 commits November 14, 2024 10:37

Migrate tests to vitest

147aaac

Fix test suites

068daa6

Remove chai dependency

9f6903f

Fix compute_state_display tests

b8dcf00

Fix resolveTimeZone

bc0b5a2

Reduces test pipeline

a337d70

github-actions bot added the GitHub Actions Pull requests that update GitHub Actions code label Nov 14, 2024

Revert test ci

df607aa

github-actions bot removed the GitHub Actions Pull requests that update GitHub Actions code label Nov 14, 2024

wendevlin and others added 3 commits November 19, 2024 14:33

Merge branch 'dev' of github.com:home-assistant/frontend into rspack

85c02c4

optimize chunk filtering

9d4d7c4

Merge branch 'dev' of github.com:home-assistant/frontend into rspack

6cc64ce

github-actions bot added the Design Related to Home Assistant design gallery label Nov 21, 2024

wendevlin added 7 commits November 21, 2024 16:22

Migrate landing-page to rspack

ece7364

Update rspack dependencies

76f5682

Add rsdoctor

3fdd206

Fix prod build bundle size

fc1d179

Merge branch 'dev' of github.com:home-assistant/frontend into rspack

51ddec2

Use rsdoctor for demo stats

e4841e1

Remove unused webpack configs

3d7ce38

wendevlin marked this pull request as ready for review November 22, 2024 10:32

MindFreeze previously approved these changes Nov 22, 2024

View reviewed changes

MindFreeze reviewed Nov 22, 2024

View reviewed changes

build-scripts/rspack.cjs Outdated Show resolved Hide resolved

wendevlin dismissed MindFreeze’s stale review via b631fb0 November 25, 2024 06:40

Update build-scripts/rspack.cjs

b631fb0

Co-authored-by: Petar Petrov <[email protected]>

wendevlin and others added 2 commits November 26, 2024 13:30

Merge branch 'dev' into rspack

819b38e

Fix eslint

109d55e

bramkragten reviewed Nov 26, 2024

View reviewed changes

build-scripts/rspack.cjs Outdated Show resolved Hide resolved

wendevlin added 2 commits November 26, 2024 14:01

Update rspack

fea4c50

Remove unused code

bdd5444

bramkragten approved these changes Nov 26, 2024

View reviewed changes

bramkragten merged commit bd0bfc1 into dev Nov 26, 2024
15 checks passed

bramkragten deleted the rspack branch November 26, 2024 13:49

steverep reviewed Dec 9, 2024

View reviewed changes

cgarwood mentioned this pull request Dec 10, 2024

Frontend Development Build Not Working #23231

Open

4 tasks

steverep reviewed Dec 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rspack #22807

Rspack #22807

wendevlin commented Nov 13, 2024

coderabbitai bot commented Nov 13, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

MindFreeze commented Nov 19, 2024 •

edited

Loading

MindFreeze commented Nov 25, 2024

steverep Dec 9, 2024

steverep Dec 9, 2024

steverep Dec 10, 2024

wendevlin Dec 10, 2024

steverep Dec 10, 2024

wendevlin Dec 10, 2024

steverep Dec 14, 2024

wendevlin Dec 19, 2024

Rspack #22807

Rspack #22807

Conversation

wendevlin commented Nov 13, 2024

Breaking change

Proposed change

Type of change

Example configuration

Additional information

Checklist

coderabbitai bot commented Nov 13, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

MindFreeze commented Nov 19, 2024 • edited Loading

MindFreeze commented Nov 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderabbitai bot commented Nov 13, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

MindFreeze commented Nov 19, 2024 •

edited

Loading