Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
By default
python -m build
will create both sdist and a wheel. @balloob mentioned to me that we hit the upload limit today with both files being around 32MB each. With this PR both will still be build, but twine will only upload the wheel.Why continue building both?
That guarantees that the wheel can indeed be build from the sdist. When using the
-w
flag forbuild
, the build would happen from the source files instead. https://pypa-build.readthedocs.io/en/latest/#python--m-buildWhy choose wheels over sdist?
Pip does prefer wheels as they are much faster to install. For sdist, pip would first build the wheel itself before installing it. We don't use any c-extensions and the wheel is thus not platform dependent. Shown by the current wheel tags
py3-none-any
./CC: @bramkragten
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: