Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only upload wheels to PyPI #11514

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Feb 2, 2022

Proposed change

By default python -m build will create both sdist and a wheel. @balloob mentioned to me that we hit the upload limit today with both files being around 32MB each. With this PR both will still be build, but twine will only upload the wheel.

Why continue building both?
That guarantees that the wheel can indeed be build from the sdist. When using the -w flag for build, the build would happen from the source files instead. https://pypa-build.readthedocs.io/en/latest/#python--m-build

Why choose wheels over sdist?
Pip does prefer wheels as they are much faster to install. For sdist, pip would first build the wheel itself before installing it. We don't use any c-extensions and the wheel is thus not platform dependent. Shown by the current wheel tags py3-none-any.

/CC: @bramkragten

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@cdce8p cdce8p changed the title Upload only wheels to PyPI Only upload wheels to PyPI Feb 2, 2022
@cdce8p cdce8p force-pushed the upload-wheels-only branch from f0a636b to 304bf92 Compare February 2, 2022 17:03
@balloob balloob merged commit 866a57c into home-assistant:dev Feb 2, 2022
@cdce8p cdce8p deleted the upload-wheels-only branch February 2, 2022 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants