Skip to content

Add windows, macOS and freebsd jobs #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2021
Merged

Conversation

ethercrow
Copy link
Contributor

No description provided.

@ethercrow
Copy link
Contributor Author

Curiously, the freebsd job complained about this:

          t_toTitle_1stNotLower:   FAIL
            *** Failed! Falsified (after 55 tests and 5 shrinks):
            "\4322"
            Use --quickcheck-replay=174726 to reproduce.

@Bodigrim
Copy link
Contributor

Bodigrim commented Apr 2, 2021

Yeah, I've seen t_toTitle_1stNotLower test failure couple of times before :(

@ethercrow ethercrow force-pushed the more-ci branch 2 times, most recently from db268c0 to ab59892 Compare April 2, 2021 13:56
@ethercrow
Copy link
Contributor Author

There's seems to be a windows specific issue:

hGetContents_crash:            FAIL
      Exception: .\cra4F80.txt: DeleteFile "\\\\?\\D:\\a\\text\\text\\cra4F80.txt": permission denied (The process cannot access the file because it is being used by another process.)

@Bodigrim didn't bytestring have something similar?

@Bodigrim
Copy link
Contributor

Bodigrim commented Apr 2, 2021

@ethercrow sounds similar to haskell/bytestring#320

Bodigrim
Bodigrim previously approved these changes Apr 3, 2021
Copy link
Contributor

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@ethercrow ethercrow marked this pull request as ready for review April 4, 2021 17:25
@ethercrow
Copy link
Contributor Author

Now we know that the benchmark suite doesn't build on Windows:

benchmarks\cbits-bench\time_iconv.c:1:10: error:
     fatal error: iconv.h: No such file or directory
        1 | #include <iconv.h>
          |          ^~~~~~~~~
  |
1 | #include <iconv.h>

  |          ^
compilation terminated.
`gcc.exe' failed in phase `C Compiler'. (Exit code: 1)

@Bodigrim
Copy link
Contributor

Bodigrim commented Apr 5, 2021

Ahh, interesting. I think it's acceptable to remove iconv benchmark with all relevant cbits: it is not particularly important nowadays. We should not expect iconv being present out of the box on non-Windows platforms either, and I do not feel benchmarking it is worth environmental complications.

@phadej
Copy link
Contributor

phadej commented Apr 5, 2021

FWIW, iconv is always there on non-Windows platforms. GHC relies on it. https://hackage.haskell.org/package/base-4.15.0.0/docs/src/GHC-IO-Encoding-Iconv.html#iconvEncoding is one example.

In other words, you can reasonably expect iconv to be present on non-Windows platforms.

@ethercrow
Copy link
Contributor Author

For now I just removed building benchmarks on windows.

@Bodigrim Bodigrim merged commit 314442d into haskell:master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants