Fix #219 #229
Merged
Fix #219 #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
reviewed
Jan 13, 2022
When `execvpe` is not available we use `find_executable` to search for the executable prior to `fork`ing (fixing GHC #19994). However, previously we failed to account for the fact that `exec` will be called from a different working directory than that of the spawning process if the user has set `cwd`. Fix this by teaching `find_executable` to search relative to the requested working directory. Fixes haskell#219.
It turns out the autoconf upper-cases the symbol name.
snoyberg
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #219 by ensuring that
find_executablerespects the working directory requested by the user.I also fix an orthogonal bug which meant that
execvpewouldn't be used, even if available.