Skip to content

Introduce EVENT_TICKY_BEGIN_SAMPLE #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Introduce EVENT_TICKY_BEGIN_SAMPLE #76

merged 3 commits into from
Apr 27, 2021

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Apr 23, 2021

No description provided.

@maoe
Copy link
Member

maoe commented Apr 24, 2021

Thanks! The code looks fine to me.

Could you add a small eventlog file which contains the new event with the expected ghc-events show output like you did in #60?

@maoe maoe self-requested a review April 24, 2021 14:17
@maoe
Copy link
Member

maoe commented Apr 27, 2021

Looks perfect! Thank you.

@maoe maoe merged commit ff157bb into haskell:master Apr 27, 2021
@nineonine
Copy link
Contributor

@maoe Can we please push new version containing this change to hackage? We would like to use this in nofib.

@maoe
Copy link
Member

maoe commented May 6, 2021

Sure, will do later today.

@maoe
Copy link
Member

maoe commented May 6, 2021

@nineonine
Copy link
Contributor

Thanks @maoe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants